This is in preparation for generating notifications when new members are added to teams (#13945). To call the notification backend (`services/notify`), we need the corresponding methods to be outside of `models/`, to avoid generating an import cycle.
It is also an occasion to clean up the structure of the code base somewhat: those methods were in `models/org_team.go` - most of which should actually be in a service. Given that those methods are currently used in various places, I haven't done the move fully yet (it's a lot of churn).
The second commit changes one of those methods to take ORM objects instead of database ids, to make it easier to pass those to a future notification method. The corresponding ORM objects are available on all call sites so this shouldn't have any performance impact.
I'm experimenting with submitting such refactors as separate PRs, instead of including them in the same PR as the feature they support - do let me know if you prefer that, or if you'd rather keep those in the same PR.
## Checklist
### Compliance
- [x] I confirm that I make this contribution in accordance with [Forgejo's AI Agreement](9084720dc6/AIAgreement.md).
### Tests for Go changes
(can be removed for JavaScript changes)
- I added test coverage for Go changes...
- [x] in their respective `*_test.go` for unit tests.
- [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I ran...
- [x] `make pr-go` before pushing
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/15198
Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
Hi there! Tired of big platforms playing monopoly?
Providing Git hosting for your project, friends, company or community?
Forgejo (/for'd͡ʒe.jo/ inspired by forĝejo – the Esperanto word for forge) has you covered with its intuitive interface,
light and easy hosting and a lot of built-in functionality.
Forgejo was created in 2022
because we think that the project should be owned by an independent community.
If you second that, then Forgejo is for you!
Our promise: Independent Free/Libre Software forever!
What does Forgejo offer?
If you like any of the following, Forgejo is literally meant for you:
Lightweight: Forgejo can easily be hosted on nearly every machine.
Running on a Raspberry? Small cloud instance? No problem!
Project management: Besides Git hosting, Forgejo offers issues,
pull requests, wikis, kanban boards and much more to coordinate with your team.
Publishing: Have something to share? Use releases to host your software for download,
or use the package registry to publish it for docker, npm and many other package managers.
Customizable: Want to change your look? Change some settings?
There are many config switches to make Forgejo work exactly like you want.
Powerful: Organizations & team permissions, CI integration, Code Search, LDAP, OAuth and much more.
If you have advanced needs, Forgejo has you covered.
Privacy: From update checker to default settings: Forgejo is built to be privacy first for you and your crew.
Federation: (WIP) We are actively working to connect software forges with each other through ActivityPub,
and create a collaborative network of personal instances.
Forgejo is distributed under the terms of the GPL version 3.0 or any later version.
The agreement for this license was documented in June 2023 and implemented during the development of Forgejo v9.0. All Forgejo versions before v9.0 are distributed under the MIT license.
Get involved
If you are interested in making Forgejo better, either by reporting a bug or by changing the governance, please take a look at the contribution guide.